Fix wrapped row navigation in react-tree-grid#660
Merged
Conversation
bsunderhus
force-pushed
the
fix/react-tree-grid-wrapped-row-navigation
branch
from
f35fa53 to
9eca12f
Compare
bsunderhus
force-pushed
the
fix/react-tree-grid-wrapped-row-navigation
branch
from
9eca12f to
518103e
Compare
mshoho
reviewed
Jun 22, 2026
|
|
||
| const siblingLevel = Number(sibling.getAttribute('aria-level')); | ||
|
|
||
| if (Number.isNaN(siblingLevel)) { |
Member
There was a problem hiding this comment.
Worth confirming: the walker now scans the whole treegrid rather than just direct siblings. If any role="row" without an aria-level can appear between data rows (e.g. a column-header row), it would hit this NaN branch and return none, disabling level navigation in that direction. Fine for the current fixtures since every row has a level — just flagging the assumption.
mshoho
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix TreeGrid level navigation when virtualized rows are wrapped in additional container elements.
What changed
useTreeGridLevelNavigationto traverse rows lazily within the current treegrid instead of relying on direct row siblingsTreeGridRowcontainers@fluentui-contrib/react-tree-gridValidation
yarn nx run react-tree-grid:test -- --testPathPattern=useTreeGridLevelNavigation.testyarn nx run react-tree-grid:component-test --skipInstall